[all-commits] [llvm/llvm-project] af3fb0: [Frontend] Simplify PrecompiledPreamble::PCHStorag...

Sam McCall via All-commits all-commits at lists.llvm.org
Thu Apr 21 09:10:44 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af3fb071545918f2de61142fa12d8782e5a37fa5
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M clang/include/clang/Frontend/PrecompiledPreamble.h
    M clang/lib/Frontend/PrecompiledPreamble.cpp

  Log Message:
  [Frontend] Simplify PrecompiledPreamble::PCHStorage. NFC

- Remove fiddly union, preambles are heavyweight
- Remove fiddly move constructors in TempPCHFile and PCHStorage, use unique_ptr
- Remove unneccesary accessors on PCHStorage
- Remove trivial InMemoryStorage
- Move implementation details into cpp file

This is a prefactoring, followup change will change the in-memory PCHStorage to
avoid extra string copies while creating it.

Differential Revision: https://reviews.llvm.org/D124177

More information about the All-commits mailing list