[all-commits] [llvm/llvm-project] e1c0d2: [clangd] Correctly identify self-contained headers...

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Thu Apr 21 08:00:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e1c0d2fb8272dd7f8e406334ac14077154217031
      https://github.com/llvm/llvm-project/commit/e1c0d2fb8272dd7f8e406334ac14077154217031
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M clang-tools-extra/clangd/Headers.cpp
    M clang-tools-extra/clangd/unittests/HeadersTests.cpp
    M clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp

  Log Message:
  -----------
  [clangd] Correctly identify self-contained headers included rercursively

Right now when exiting the file Headers.cpp will identify the recursive
inclusion (with a new FileID) as non self-contained and will add it to the set
from which it will never be removed. As a result, we get incorrect results in
the IncludeStructure and Include Cleaner. This patch is a fix.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D124166


  Commit: 9f05b111ee1fc48974ed515c865bdaddb5998d01
      https://github.com/llvm/llvm-project/commit/9f05b111ee1fc48974ed515c865bdaddb5998d01
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M clang-tools-extra/clangd/Headers.cpp
    M clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp

  Log Message:
  -----------
  [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

Add limited support for "IWYU pragma: export" - for now it just supresses the
warning similar to "IWYU pragma: keep".

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D124170


Compare: https://github.com/llvm/llvm-project/compare/1f71b5a38605...9f05b111ee1f


More information about the All-commits mailing list