[all-commits] [llvm/llvm-project] 610a0e: [ELF] Assert on invalid GOT or PLT relocations

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Wed Apr 20 10:46:43 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 610a0e8b5368853b0e67b16812c0fb61d8900356
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-04-20 (Wed, 20 Apr 2022)

  Changed paths:
    M lld/ELF/SyntheticSections.cpp

  Log Message:
  [ELF] Assert on invalid GOT or PLT relocations

Because of https://llvm.org/PR50675, we can end up producing a PLT
relocation referencing a symbol that's dropped from the dynamic symbol
table, which in turn causes a crash at runtime. We ran into this again
recently, resulting in crashes for our users. A subsequent diff will fix
that issue, but add an assert to catch it if it happens again.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D123985

More information about the All-commits mailing list