[all-commits] [llvm/llvm-project] 454d1d: [Concepts] Fix overload resolution bug with constr...

[royjacobson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 454d1df9423c95e54c3a2f5cb58d864096032d09
      https://github.com/llvm/llvm-project/commit/454d1df9423c95e54c3a2f5cb58d864096032d09
  Author: Roy Jacobson <roi.jacobson1 at gmail.com>
  Date:   2022-04-19 (Tue, 19 Apr 2022)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/SemaOverload.cpp
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    A clang/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p6.cpp

  Log Message:
  -----------
  [Concepts] Fix overload resolution bug with constrained candidates

When doing overload resolution, we have to check that candidates' parameter types are equal before trying to find a better candidate through checking which candidate is more constrained.
This revision adds this missing check and makes us diagnose those cases as ambiguous calls when the types are not equal.

Fixes GitHub issue https://github.com/llvm/llvm-project/issues/53640

Reviewed By: erichkeane

Differential Revision: https://reviews.llvm.org/D123182