[all-commits] [llvm/llvm-project] ef9460: [libcxx] [test] Use LIBCPP_ASSERT for libc++-speci...

Jonathan Wakely via All-commits all-commits at lists.llvm.org
Sat Apr 16 16:25:28 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef94609d6ebe981767788e6877b0b3b731d425af
  Author: Jonathan Wakely <jwakely at redhat.com>
  Date:   2022-04-17 (Sun, 17 Apr 2022)

  Changed paths:
    M libcxx/test/std/re/re.badexp/regex_error.pass.cpp
    M libcxx/test/std/re/re.const/re.synopt/syntax_option_type.pass.cpp

  Log Message:
  [libcxx] [test] Use LIBCPP_ASSERT for libc++-specific checks

This makes it a little easier to reuse the libc++ tests for another
std::lib (specifically libstdc++).

The regex_error::what() strings are different in other
implementations, so should be tested with LIBCPP_ASSERT so that those
checks are skipped for other implementations.

The value of ECMAScript constant is non-zero in other implementations,
and conditionally for libc++, so adjust the preprocessor condition for
that too.

Reviewed By: ldionne, #libc, philnik, Mordante

Spies: Mordante, philnik, libcxx-commits

Differential Revision: https://reviews.llvm.org/D122574

More information about the All-commits mailing list