[all-commits] [llvm/llvm-project] 64c045: Treat `std::move`, `forward`, and `move_if_noexcep...

Richard Smith via All-commits all-commits at lists.llvm.org
Fri Apr 15 14:10:03 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64c045e25b8471bbb572bd29159c294a82a86a25
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2022-04-15 (Fri, 15 Apr 2022)

  Changed paths:
    M clang/docs/CommandGuide/clang.rst
    M clang/docs/ReleaseNotes.rst
    M clang/include/clang/Basic/Builtins.def
    M clang/include/clang/Basic/Builtins.h
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/ExprConstant.cpp
    M clang/lib/Analysis/BodyFarm.cpp
    M clang/lib/Basic/Builtins.cpp
    M clang/lib/CodeGen/CGBuiltin.cpp
    M clang/lib/CodeGen/CGCall.cpp
    M clang/lib/Sema/SemaChecking.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/lib/Sema/SemaExpr.cpp
    M clang/lib/Sema/SemaExprCXX.cpp
    M clang/lib/Sema/SemaInit.cpp
    M clang/lib/Sema/SemaOverload.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/test/Analysis/use-after-move.cpp
    A clang/test/CodeGenCXX/builtin-std-move.cpp
    M clang/test/CodeGenCXX/microsoft-abi-throw.cpp
    A clang/test/SemaCXX/builtin-std-move-nobuiltin.cpp
    A clang/test/SemaCXX/builtin-std-move.cpp
    M clang/test/SemaCXX/unqualified-std-call-fixits.cpp
    M clang/test/SemaCXX/unqualified-std-call.cpp
    M clang/test/SemaCXX/warn-consumed-analysis.cpp

  Log Message:
  Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

We still require these functions to be declared before they can be used,
but don't instantiate their definitions unless their addresses are
taken. Instead, code generation, constant evaluation, and static
analysis are given direct knowledge of their effect.

This change aims to reduce various costs associated with these functions
-- per-instantiation memory costs, compile time and memory costs due to
creating out-of-line copies and inlining them, code size at -O0, and so
on -- so that they are not substantially more expensive than a cast.
Most of these improvements are very small, but I measured a 3% decrease
in -O0 object file size for a simple C++ source file using the standard
library after this change.

We now automatically infer the `const` and `nothrow` attributes on these
now-builtin functions, in particular meaning that we get a warning for
an unused call to one of these functions.

In C++20 onwards, we disallow taking the addresses of these functions,
per the C++20 "addressable function" rule. In earlier language modes, a
compatibility warning is produced but the address can still be taken.

The same infrastructure is extended to the existing MSVC builtin
`__GetExceptionInfo`, which is now only recognized in namespace `std`
like it always should have been.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D123345

More information about the All-commits mailing list