[all-commits] [llvm/llvm-project] 343f3d: [lldb] Fix a bug in the decorator matching logic.

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Apr 13 15:07:45 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 343f3de559c636dcec941613dca91e4fff6547a3
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-04-13 (Wed, 13 Apr 2022)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/decorators.py
    A lldb/test/API/test_utils/TestDecorators.py

  Log Message:
  [lldb] Fix a bug in the decorator matching logic.

This changes the decorator helper `_match_decorator_property` to
consider `None` as the actual value as not a match. Using `None` for the
pattern continues to be considered a match.

I discovered the issue because marking a test as NO_DEBUG_INFO_TESTCASE
will cause the call to `self.getDebugInfo()` to return `None` and
incorrectly skip or XFAIL the corresponding test.

I used the above scenario to create a test for the decorators.

Differential revision: https://reviews.llvm.org/D123401

More information about the All-commits mailing list