[all-commits] [llvm/llvm-project] ba4537: [compiler-rt] Don't explictly ad-hoc sign dylibs o...

Nico Weber via All-commits all-commits at lists.llvm.org
Wed Apr 13 05:39:36 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba4537b22796a561dbcd7cd4e666bb5039510b21
      https://github.com/llvm/llvm-project/commit/ba4537b22796a561dbcd7cd4e666bb5039510b21
  Author: Nico Weber <thakis at chromium.org>
  Date:   2022-04-13 (Wed, 13 Apr 2022)

  Changed paths:
    M compiler-rt/cmake/Modules/AddCompilerRT.cmake

  Log Message:
  -----------
  [compiler-rt] Don't explictly ad-hoc sign dylibs on APPLE if ld is new enough

ld64 implicitly ad-hoc code-signs as of Xcode 12, and `strip` and friends know
how keep this special ad-hoc signature valid.

So this should have no effective behavior change, except that you can now strip
libclang_rt.asan_osx_dynamic.dylib and it'll still have a valid ad-hoc
signature, instead of strip printing "warning: changes being made to the file
will invalidate the code signature in:" and making the ad-hoc code signature
invalid.

Differential Revision: https://reviews.llvm.org/D123475




More information about the All-commits mailing list