[all-commits] [llvm/llvm-project] 9107cd: [AutoUpgrade] Don't lose attributes when upgrading...

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9107cd632d5088076411ae5253f73dcd9cd650e9
      https://github.com/llvm/llvm-project/commit/9107cd632d5088076411ae5253f73dcd9cd650e9
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-04-13 (Wed, 13 Apr 2022)

  Changed paths:
    M llvm/lib/IR/AutoUpgrade.cpp
    M llvm/test/Bitcode/upgrade-memory-intrinsics.ll
    M llvm/test/Transforms/IROutliner/illegal-memset.ll
    M llvm/test/Transforms/IROutliner/outline-memset.ll

  Log Message:
  -----------
  [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics

The original AutoUpgrade code from 1e68724d24ba38de7c7cdb2e1939d78c8b37cc0d
did not retain existing attributes. I noticed this in some downstream test
cases, but it turns out there are also two affected testcase upstream.

Differential Revision: https://reviews.llvm.org/D121971


  Commit: 32a353a5e08628403422a1f71e6500bc1f68e8fb
      https://github.com/llvm/llvm-project/commit/32a353a5e08628403422a1f71e6500bc1f68e8fb
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-04-13 (Wed, 13 Apr 2022)

  Changed paths:
    A llvm/test/CodeGen/AArch64/fabd-no-neon.ll

  Log Message:
  -----------
  [AArch64] Baseline test for D123491


  Commit: ee44896cf42d3360f7e0229c360258c92262a47b
      https://github.com/llvm/llvm-project/commit/ee44896cf42d3360f7e0229c360258c92262a47b
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-04-13 (Wed, 13 Apr 2022)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrInfo.td
    M llvm/test/CodeGen/AArch64/fabd-no-neon.ll

  Log Message:
  -----------
  [AArch64] Add missing HasNEON predicate in scalar FABD patterns

I was trying to compile with -march=+nosimd and hit the following assertion:
`Attempting to emit FABD64 instruction but the Feature_HasNEON predicate(s) are not met`.
This adds a HasNEON predicate to the patterns which was omitted in commit
21d9b33d62772c58267cc0aa725e35ac9a4661db for some reason.
The new code generation matches GCC with -mcpu=<cpu>+nosimd:
https://godbolt.org/z/n1Y7xh5jo

Differential Revision: https://reviews.llvm.org/D123491


Compare: https://github.com/llvm/llvm-project/compare/44271e7c5582...ee44896cf42d