[all-commits] [llvm/llvm-project] efdc90: Revert "[MSan] Ensure argument shadow initialized ...

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Apr 12 14:53:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: efdc90baaaebd7d9a8aa72735bd605ee04ac5749
      https://github.com/llvm/llvm-project/commit/efdc90baaaebd7d9a8aa72735bd605ee04ac5749
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2022-04-12 (Tue, 12 Apr 2022)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
    R llvm/test/Instrumentation/MemorySanitizer/opaque-ptr.ll

  Log Message:
  -----------
  Revert "[MSan] Ensure argument shadow initialized on memcpy"

Invalid author.

This reverts commit 163a9f4552bea71b2d53126a5f74f9a1b47d2865.


  Commit: 0adadfa68f82c1505e06ffb56c0d7e63dc3ac206
      https://github.com/llvm/llvm-project/commit/0adadfa68f82c1505e06ffb56c0d7e63dc3ac206
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-04-12 (Tue, 12 Apr 2022)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
    A llvm/test/Instrumentation/MemorySanitizer/opaque-ptr.ll

  Log Message:
  -----------
  [MSan] Ensure argument shadow initialized on memcpy

We need to explicitly query the shadow here, because it is lazily
initialized for byval arguments. Without opaque pointers this used to
mostly work out, because there would be a bitcast to `i8*` present, and
that would query, and copy in case of byval, the argument shadow.

Reviewed By: vitalybuka, eugenis

Differential Revision: https://reviews.llvm.org/D123602


Compare: https://github.com/llvm/llvm-project/compare/cd0a5889d71c...0adadfa68f82


More information about the All-commits mailing list