[all-commits] [llvm/llvm-project] e758b7: [llvm-pdbutil] Fix broken '-modi' option after cha...

Carlos Alberto Enciso via All-commits all-commits at lists.llvm.org
Mon Apr 11 22:31:53 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e758b77161a70d7e7260d8f52bf161a89d73af8a
  Author: Carlos Alberto Enciso <carlos.alberto.enciso at gmail.com>
  Date:   2022-04-12 (Tue, 12 Apr 2022)

  Changed paths:
    M llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h
    M llvm/include/llvm/DebugInfo/PDB/Native/LinePrinter.h
    M llvm/lib/DebugInfo/PDB/Native/InputFile.cpp
    A llvm/test/tools/llvm-pdbutil/modi.test
    M llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp

  Log Message:
  [llvm-pdbutil] Fix broken '-modi' option after change D122226.

The change described by:


Moved some llvm-pdbutil functionality to the debug PDB library.

This patch addresses a broken '-modi' argument handling, which
causes an assertion if its value is other than '0' or '1'.

In addition, it moves the assertion for the number of occurrences
of the '-modi' argument from the PDB library into the llvm-pdbutil

Reviewed By: zequanwu

Differential Revision: https://reviews.llvm.org/D123483

More information about the All-commits mailing list