[all-commits] [llvm/llvm-project] 195a8b: don't extra notify ModulesDidLoad() from LoadModul...

Luboš Luňák via All-commits all-commits at lists.llvm.org
Mon Apr 11 15:38:01 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 195a8b977efe7a087709692f98821cdab1826346
  Author: Luboš Luňák <l.lunak at centrum.cz>
  Date:   2022-04-12 (Tue, 12 Apr 2022)

  Changed paths:
    M lldb/include/lldb/Target/DynamicLoader.h
    M lldb/source/Core/DynamicLoader.cpp
    M lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py

  Log Message:
  don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

Places calling LoadModuleAtAddress() already call ModulesDidLoad()
after a loop calling LoadModuleAtAddress(), so it's not necessary
to call it from there, and the batched ModulesDidLoad() may be
more efficient than this place calling it one after one.

This also makes the ModuleLoadedNotifys test pass on Linux now that
the duplicates no longer bring down the average of modules notified
per call.

Differential Revision: https://reviews.llvm.org/D123128

More information about the All-commits mailing list