[all-commits] [llvm/llvm-project] d16a63: [AVR] Merge AVRRelaxMemOperations into AVRExpandPs...

Patryk Wychowaniec via All-commits all-commits at lists.llvm.org
Sun Apr 10 19:42:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d16a631c124fdc27dd33037a826804ebf21dc582
      https://github.com/llvm/llvm-project/commit/d16a631c124fdc27dd33037a826804ebf21dc582
  Author: Patryk Wychowaniec <pwychowaniec at pm.me>
  Date:   2022-04-11 (Mon, 11 Apr 2022)

  Changed paths:
    M clang/docs/tools/clang-formatted-files.txt
    M llvm/lib/Target/AVR/AVR.h
    M llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
    R llvm/lib/Target/AVR/AVRRelaxMemOperations.cpp
    M llvm/lib/Target/AVR/AVRTargetMachine.cpp
    M llvm/lib/Target/AVR/CMakeLists.txt
    M llvm/test/CodeGen/AVR/pseudo/STDWPtrQRr.mir
    R llvm/test/CodeGen/AVR/relax-mem/STDWPtrQRr.mir
    M llvm/utils/gn/secondary/llvm/lib/Target/AVR/BUILD.gn

  Log Message:
  -----------
  [AVR] Merge AVRRelaxMemOperations into AVRExpandPseudoInsts

This commit contains a refactoring that merges AVRRelaxMemOperations
into AVRExpandPseudoInsts, so that we have a single place in code that
expands the STDWPtrQRr opcode.

Seizing the day, I've also fixed a couple of potential bugs with our
previous implementation (e.g. when the destination register was killed,
the previous implementation would try to .addDef() that killed
register, crashing LLVM in the process - that's fixed now, as proved by
the test).

Reviewed By: benshi001

Differential Revision: https://reviews.llvm.org/D122533




More information about the All-commits mailing list