[all-commits] [llvm/llvm-project] 1c9415: [compiler-rt][builtins] Move DMB definition to syn...

pzhengqc via All-commits all-commits at lists.llvm.org
Thu Apr 7 14:58:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c9415806ba6d0d48a160637eea7d1b70efaae69
      https://github.com/llvm/llvm-project/commit/1c9415806ba6d0d48a160637eea7d1b70efaae69
  Author: Pengxuan Zheng <pzheng at quicinc.com>
  Date:   2022-04-07 (Thu, 07 Apr 2022)

  Changed paths:
    M compiler-rt/lib/builtins/arm/sync-ops.h
    M compiler-rt/lib/builtins/assembly.h

  Log Message:
  -----------
  [compiler-rt][builtins] Move DMB definition to syn-ops.h

Compiler-rt cross-compile for ARMv5 fails because D99282 made it an error if DMB
is used for any pre-ARMv6 targets. More specifically, the "#error only supported
on ARMv6+" added in D99282 will cause compilation to fail when any source file
which includes assembly.h are compiled for pre-ARMv6 targets. Since the only
place where DMB is used is syn-ops.h (which is only included by
arm/sync_fetch_and_* and these files are excluded from being built for older
targets), this patch moves the definition there to avoid the issues described
above.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D123105




More information about the All-commits mailing list