[all-commits] [llvm/llvm-project] f42f21: [lldb][gui] handle Ctrl+C to stop a running process

Luboš Luňák via All-commits all-commits at lists.llvm.org
Thu Apr 7 13:00:19 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f42f21746cb8b940518bf37e5917d61542d278b7
      https://github.com/llvm/llvm-project/commit/f42f21746cb8b940518bf37e5917d61542d278b7
  Author: Luboš Luňák <l.lunak at centrum.cz>
  Date:   2022-04-07 (Thu, 07 Apr 2022)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [lldb][gui] handle Ctrl+C to stop a running process

Differential Revision: https://reviews.llvm.org/D123015


  Commit: c29a51b3a257908aebc01cd7c4655665db317d66
      https://github.com/llvm/llvm-project/commit/c29a51b3a257908aebc01cd7c4655665db317d66
  Author: Luboš Luňák <l.lunak at centrum.cz>
  Date:   2022-04-07 (Thu, 07 Apr 2022)

  Changed paths:
    M lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [lldb][gui] remove the "expand" diamond for variables where expanding fails

If the variables view shows a variable that is a struct that has
MightHaveChildren(), the expand diamond is shown, but if trying to expand
it and it's not possible (e.g. incomplete type), remove the expand diamond
to visualize that it can't be in fact expanded. Otherwise it feels kinda
weird that a tree item cannot be expanded even though it "should".

I guess the MightHaveChildren() checking means that GetChildren() may
be expensive, so also do not call it for rows that are not expanded.

Differential Revision: https://reviews.llvm.org/D123008


Compare: https://github.com/llvm/llvm-project/compare/65942554e23f...c29a51b3a257


More information about the All-commits mailing list