[all-commits] [llvm/llvm-project] dd8269: [libc++abi] Remove XFAIL on arm64

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Apr 6 16:08:18 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd8269c54e9bf6f886cecb6df2aec9b90fcc645f
      https://github.com/llvm/llvm-project/commit/dd8269c54e9bf6f886cecb6df2aec9b90fcc645f
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-04-06 (Wed, 06 Apr 2022)

  Changed paths:
    M libcxxabi/test/thread_local_destruction_order.pass.cpp

  Log Message:
  -----------
  [libc++abi] Remove XFAIL on arm64

The underlying TLS destruction order bug has been fixed in the OS. This
would technically still fail when running on top of macOS < 12, however
we don't have a good way of encoding that using Lit features. Indeed,
the existing target=<FOO> Lit feature encodes the deployment target,
not the actual runtime system that the tests are being run on.

If this test starts failing on your machine after this patch, upgrading
to macOS 12 should solve the problem.




More information about the All-commits mailing list