[all-commits] [llvm/llvm-project] c32f8f: [unittests] fix intermittent SupportTests failures

Yuanfang Chen via All-commits all-commits at lists.llvm.org
Tue Apr 5 18:19:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c32f8f34614d89dbe4978b71b6e2a6da17b1b0d4
      https://github.com/llvm/llvm-project/commit/c32f8f34614d89dbe4978b71b6e2a6da17b1b0d4
  Author: Yuanfang Chen <yuanfang.chen at sony.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M llvm/unittests/Support/CommandLineTest.cpp
    M llvm/unittests/Support/ErrorTest.cpp

  Log Message:
  -----------
  [unittests] fix intermittent SupportTests failures

by invoking `SupportTests --gtest_shuffle=1`.

`HideUnrelatedOptions`/`HideUnrelatedOptionsMulti` failed due to other
tests calling `cl::ResetCommandLineParser()` which causes default
options to be removed.

`ExitOnError` would hang due to the threading environment. Renaming it
as `*Deathtest` is the recommended practice by GTest docs.




More information about the All-commits mailing list