[all-commits] [llvm/llvm-project] ade148: [mlir-vscode] Add better resolution for server fil...

River Riddle via All-commits all-commits at lists.llvm.org
Tue Apr 5 13:43:55 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ade148d936be84aa5df451de30201bc4f84e607c
      https://github.com/llvm/llvm-project/commit/ade148d936be84aa5df451de30201bc4f84e607c
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M mlir/utils/vscode/src/configWatcher.ts
    M mlir/utils/vscode/src/mlirContext.ts

  Log Message:
  -----------
  [mlir-vscode] Add better resolution for server file paths

We currently require that server paths are full paths, which is
fairly inconvenient for a myriad of reasons. This commit
attempts to resolve a given server path with the current workspace.

This has a nice additional affect that we can now actually have
default server paths. This means that mlir-lsp-server and
mlir-pdll-lsp-server can be transparently picked up from
build directories (i.e. generally no need for upstream users to
configure the extension).

Fixes #54627

Differential Revision: https://reviews.llvm.org/D122792


  Commit: 43c0a45a79d0697f05fe4562f4f01571b11d8f85
      https://github.com/llvm/llvm-project/commit/43c0a45a79d0697f05fe4562f4f01571b11d8f85
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M mlir/utils/vscode/package.json
    M mlir/utils/vscode/src/config.ts
    M mlir/utils/vscode/src/configWatcher.ts
    M mlir/utils/vscode/src/mlirContext.ts

  Log Message:
  -----------
  [mlir-vscode] Add better support for multiple workspace folders

We currently only launch one set of language clients when starting the extension,
but this has the unfortunate effect of applying the same settings to all workspace
folders. This commit adds support for multiple workspace folders by launching
a server for each folder in the workspace. This allows for having different servers
for different workspace folders, e.g. when there are multiple MLIR projects in
the same workspace.

Differential Revision: https://reviews.llvm.org/D122793


Compare: https://github.com/llvm/llvm-project/compare/2e51a3221956...43c0a45a79d0


More information about the All-commits mailing list