[all-commits] [llvm/llvm-project] c54ad1: [Lint][Verifier] NFC: Rename 'Assert*' macros to '...

[Tom Honermann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c54ad1360248e28a436a6a6c560ba5952d8e98cb
      https://github.com/llvm/llvm-project/commit/c54ad1360248e28a436a6a6c560ba5952d8e98cb
  Author: Tom Honermann <tom.honermann at intel.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M llvm/lib/Analysis/Lint.cpp
    M llvm/lib/IR/Verifier.cpp

  Log Message:
  -----------
  [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'.

The LLVM IR verifier and analysis linter defines and uses several macros in
code that performs validation of IR expectations. Previously, these macros
were named with an 'Assert' prefix. These names were misleading since the
macro definitions are not conditioned on build kind; they are defined
identically in builds that have asserts enabled and those that do not. This
was confusing since an LLVM developer might expect these macros to be
conditionally enabled as 'assert' is. Further confusion was possible since
the LLVM IR verifier is implicitly disabled (in Clang::ConstructJob()) for
builds without asserts enabled, but only for Clang driver invocations; not
for clang -cc1 invocations. This could make it appear that the macros were
not active for builds without asserts enabled, e.g. when investigating
behavior using the Clang driver, and thus lead to surprises when running
tests that exercise the clang -cc1 interface.

This change renames this set of macros as follows:
  Assert -> Check
  AssertDI -> CheckDI
  AssertTBAA -> CheckTBAA


  Commit: 3531a4fa3b7038d43ac20f56871da88aa25bf53d
      https://github.com/llvm/llvm-project/commit/3531a4fa3b7038d43ac20f56871da88aa25bf53d
  Author: Tom Honermann <tom.honermann at intel.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M clang/test/CodeGen/attr-target-mv.c

  Log Message:
  -----------
  [clang] NFC: Extend comdat validation in target multiversion function tests.


  Commit: 7c53fc4fe1308f5b2a7527d14ea41fabb18109b8
      https://github.com/llvm/llvm-project/commit/7c53fc4fe1308f5b2a7527d14ea41fabb18109b8
  Author: Tom Honermann <tom.honermann at intel.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGen/attr-target-clones.c

  Log Message:
  -----------
  [clang] Emit target_clones resolver functions as COMDAT.

Previously, resolver functions synthesized for target_clones multiversion
functions were not emitted as COMDAT. Now fixed.


Compare: https://github.com/llvm/llvm-project/compare/019e7b7f6ed2...7c53fc4fe130