[all-commits] [llvm/llvm-project] 09f33a: [AMDGPU][OpenCL] Remove "printf and hostcall" diag...

Scott Linder via All-commits all-commits at lists.llvm.org
Tue Apr 5 12:11:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 09f33a430b72fffe06fde9e07c0acd5c4cd2e59e
      https://github.com/llvm/llvm-project/commit/09f33a430b72fffe06fde9e07c0acd5c4cd2e59e
  Author: Scott Linder <Scott.Linder at amd.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    A clang/test/CodeGenOpenCL/amdgpu-printf.cl
    M llvm/docs/AMDGPUUsage.rst
    M llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp
    A llvm/test/CodeGen/AMDGPU/opencl-printf-and-hostcall.ll
    R llvm/test/CodeGen/AMDGPU/opencl-printf-no-hostcall.ll

  Log Message:
  -----------
  [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic

The diagnostic is unreliable, and triggers even for dead uses of
hostcall that may exist when linking the device-libs at lower
optimization levels.

Eliminate the diagnostic, and directly document the limitation for
OpenCL before code object V5.

Make some NFC changes to clarify the related code in the
MetadataStreamer.

Add a clang test to tie OCL sources containing printf to the backend IR
tests for this situation.

Reviewed By: sameerds, arsenm, yaxunl

Differential Revision: https://reviews.llvm.org/D121951




More information about the All-commits mailing list