[all-commits] [llvm/llvm-project] 09a5ea: [clang-offload-bundler] add -input/-output options

Yaxun (Sam) Liu via All-commits all-commits at lists.llvm.org
Tue Apr 5 08:13:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 09a5eae0d1952f53dffd56b9a598215aa1a1487e
      https://github.com/llvm/llvm-project/commit/09a5eae0d1952f53dffd56b9a598215aa1a1487e
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/lib/Driver/ToolChains/HIPUtility.cpp
    M clang/test/Driver/clang-offload-bundler-asserts-on.c
    M clang/test/Driver/clang-offload-bundler.c
    M clang/test/Driver/fat-archive-unbundle-ext.c
    M clang/test/Driver/fat_archive_amdgpu.cpp
    M clang/test/Driver/fat_archive_nvptx.cpp
    M clang/test/Driver/hip-device-compile.hip
    M clang/test/Driver/hip-link-bundle-archive.hip
    M clang/test/Driver/hip-link-save-temps.hip
    M clang/test/Driver/hip-output-file-name.hip
    M clang/test/Driver/hip-rdc-device-only.hip
    M clang/test/Driver/hip-save-temps.hip
    M clang/test/Driver/hip-toolchain-device-only.hip
    M clang/test/Driver/hip-toolchain-no-rdc.hip
    M clang/test/Driver/hip-toolchain-rdc-separate.hip
    M clang/test/Driver/hip-toolchain-rdc-static-lib.hip
    M clang/test/Driver/hip-toolchain-rdc.hip
    M clang/test/Driver/hip-unbundle-preproc.hip
    M clang/test/Driver/hipspv-toolchain-rdc.hip
    M clang/test/Driver/hipspv-toolchain.hip
    M clang/test/Driver/openmp-offload-gpu.c
    M clang/test/Driver/openmp-offload.c
    M clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp

  Log Message:
  -----------
  [clang-offload-bundler] add -input/-output options

Currently, clang-offload-bundler has -inputs and -outputs options that accept
values with comma as the delimiter. This causes issues with file paths
containing commas, which are valid file paths on Linux.

This add two new options -input and -output, which accept one single file,
and allow multiple instances. This allows arbitrary file paths. The old
-inputs and -outputs options will be kept for backward compatibility, but
are not allowed to be used with -input and -output options for simplicity.
In the future, -inputs and -outputs options will be phasing out.

RFC: https://discourse.llvm.org/t/rfc-adding-input-and-output-options-to-clang-offload-bundler/60049

Patch by: Siu Chi Chan

Reviewed by: Yaxun Liu

Differential Revision: https://reviews.llvm.org/D120662




More information about the All-commits mailing list