[all-commits] [llvm/llvm-project] 3de4d5: [clangd] Use stable keys for CanonicalIncludes map...

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Tue Apr 5 07:28:15 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3de4d5e6dd66165057439c69b6a03e7001ec03e0
      https://github.com/llvm/llvm-project/commit/3de4d5e6dd66165057439c69b6a03e7001ec03e0
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2022-04-05 (Tue, 05 Apr 2022)

  Changed paths:
    M clang-tools-extra/clangd/index/CanonicalIncludes.cpp
    M clang-tools-extra/clangd/index/CanonicalIncludes.h
    M clang-tools-extra/clangd/index/SymbolCollector.cpp
    M clang-tools-extra/clangd/unittests/CanonicalIncludesTests.cpp
    M clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp

  Log Message:
  -----------
  [clangd] Use stable keys for CanonicalIncludes mappings

This patch switches CanonicalInclude mappings to use `llvm::sys::fs::UniqueID` for a stable file representation because the `FileEntry::getName()` results turn out to be changing throughout the lifetime of a program (exposed in D120306). This patch makes it possible for D120306 to be re-landed and increases overall stability.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D123031




More information about the All-commits mailing list