[all-commits] [llvm/llvm-project] 5e50dd: [mlir] Rework the implementation of TypeID

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5e50dd048e3a20cde5da5d7a754dfee775ef35d6
      https://github.com/llvm/llvm-project/commit/5e50dd048e3a20cde5da5d7a754dfee775ef35d6
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-04-04 (Mon, 04 Apr 2022)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp
    M flang/lib/Optimizer/Transforms/ArrayValueCopy.cpp
    M flang/lib/Optimizer/Transforms/MemoryAllocation.cpp
    M mlir/examples/toy/Ch4/mlir/ShapeInferencePass.cpp
    M mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch5/mlir/ShapeInferencePass.cpp
    M mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp
    M mlir/examples/toy/Ch6/mlir/ShapeInferencePass.cpp
    M mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp
    M mlir/examples/toy/Ch7/mlir/ShapeInferencePass.cpp
    M mlir/include/mlir/Conversion/SCFToGPU/SCFToGPUPass.h
    M mlir/include/mlir/Pass/AnalysisManager.h
    M mlir/include/mlir/Support/TypeID.h
    M mlir/include/mlir/Tools/PDLL/AST/Types.h
    M mlir/lib/Conversion/PassDetail.h
    M mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/UnifyAliasedResourcePass.cpp
    M mlir/lib/Parser/Parser.cpp
    M mlir/lib/Support/CMakeLists.txt
    A mlir/lib/Support/TypeID.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/lib/Tools/PDLL/AST/Types.cpp
    M mlir/test/CAPI/ir.c
    M mlir/test/lib/Analysis/TestAliasAnalysis.cpp
    M mlir/test/lib/Analysis/TestCallGraph.cpp
    M mlir/test/lib/Analysis/TestLiveness.cpp
    M mlir/test/lib/Analysis/TestMatchReduction.cpp
    M mlir/test/lib/Analysis/TestMemRefBoundCheck.cpp
    M mlir/test/lib/Analysis/TestMemRefDependenceCheck.cpp
    M mlir/test/lib/Analysis/TestMemRefStrideCalculation.cpp
    M mlir/test/lib/Analysis/TestSlice.cpp
    M mlir/test/lib/Conversion/FuncToLLVM/TestConvertCallOp.cpp
    M mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
    M mlir/test/lib/Dialect/Affine/TestAffineLoopParametricTiling.cpp
    M mlir/test/lib/Dialect/Affine/TestAffineLoopUnswitching.cpp
    M mlir/test/lib/Dialect/Affine/TestLoopFusion.cpp
    M mlir/test/lib/Dialect/Affine/TestLoopMapping.cpp
    M mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
    M mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp
    M mlir/test/lib/Dialect/DLTI/TestDataLayoutQuery.cpp
    M mlir/test/lib/Dialect/Func/TestDecomposeCallGraphTypes.cpp
    M mlir/test/lib/Dialect/GPU/TestConvertGPUKernelToCubin.cpp
    M mlir/test/lib/Dialect/GPU/TestConvertGPUKernelToHsaco.cpp
    M mlir/test/lib/Dialect/GPU/TestGpuMemoryPromotion.cpp
    M mlir/test/lib/Dialect/GPU/TestGpuParallelLoopMapping.cpp
    M mlir/test/lib/Dialect/GPU/TestGpuRewrite.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgElementwiseFusion.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
    M mlir/test/lib/Dialect/Linalg/TestPadFusion.cpp
    M mlir/test/lib/Dialect/Math/TestAlgebraicSimplification.cpp
    M mlir/test/lib/Dialect/Math/TestExpandTanh.cpp
    M mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
    M mlir/test/lib/Dialect/MemRef/TestComposeSubView.cpp
    M mlir/test/lib/Dialect/MemRef/TestMultiBuffer.cpp
    M mlir/test/lib/Dialect/SCF/TestLoopParametricTiling.cpp
    M mlir/test/lib/Dialect/SCF/TestLoopUnrolling.cpp
    M mlir/test/lib/Dialect/SCF/TestSCFUtils.cpp
    M mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp
    M mlir/test/lib/Dialect/SPIRV/TestEntryPointAbi.cpp
    M mlir/test/lib/Dialect/SPIRV/TestModuleCombiner.cpp
    M mlir/test/lib/Dialect/Shape/TestShapeFunctions.cpp
    M mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp
    M mlir/test/lib/Dialect/Test/TestDialect.cpp
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp
    M mlir/test/lib/Dialect/Test/TestTraits.cpp
    M mlir/test/lib/Dialect/Tosa/TosaTestPasses.cpp
    M mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
    M mlir/test/lib/IR/TestBuiltinAttributeInterfaces.cpp
    M mlir/test/lib/IR/TestDiagnostics.cpp
    M mlir/test/lib/IR/TestDominance.cpp
    M mlir/test/lib/IR/TestFunc.cpp
    M mlir/test/lib/IR/TestInterfaces.cpp
    M mlir/test/lib/IR/TestMatchers.cpp
    M mlir/test/lib/IR/TestOpaqueLoc.cpp
    M mlir/test/lib/IR/TestOperationEquals.cpp
    M mlir/test/lib/IR/TestPrintDefUse.cpp
    M mlir/test/lib/IR/TestPrintInvalid.cpp
    M mlir/test/lib/IR/TestPrintNesting.cpp
    M mlir/test/lib/IR/TestSideEffects.cpp
    M mlir/test/lib/IR/TestSlicing.cpp
    M mlir/test/lib/IR/TestSymbolUses.cpp
    M mlir/test/lib/IR/TestTypes.cpp
    M mlir/test/lib/IR/TestVisitors.cpp
    M mlir/test/lib/IR/TestVisitorsGeneric.cpp
    M mlir/test/lib/Pass/TestDynamicPipeline.cpp
    M mlir/test/lib/Pass/TestPassManager.cpp
    M mlir/test/lib/Reducer/MLIRTestReducer.cpp
    M mlir/test/lib/Rewrite/TestPDLByteCode.cpp
    M mlir/test/lib/Transforms/TestConstantFold.cpp
    M mlir/test/lib/Transforms/TestControlFlowSink.cpp
    M mlir/test/lib/Transforms/TestInlining.cpp
    M mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp
    M mlir/tools/mlir-tblgen/DialectGen.cpp
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/PassGen.cpp
    M mlir/unittests/IR/DialectTest.cpp
    M mlir/unittests/Interfaces/DataLayoutInterfacesTest.cpp
    M mlir/unittests/Pass/AnalysisManagerTest.cpp
    M mlir/unittests/Pass/PassManagerTest.cpp
    M mlir/unittests/Transforms/Canonicalizer.cpp
    M mlir/unittests/Transforms/DialectConversion.cpp

  Log Message:
  -----------
  [mlir] Rework the implementation of TypeID

This commit restructures how TypeID is implemented to ideally avoid
the current problems related to shared libraries. This is done by changing
the "implicit" fallback path to use the name of the type, instead of using
a static template variable (which breaks shared libraries). The major downside to this
is that it adds some additional initialization costs for the implicit path. Given the
use of type names for uniqueness in the fallback, we also no longer allow types
defined in anonymous namespaces to have an implicit TypeID. To simplify defining
an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro
was added to allow for explicitly defining a TypeID directly on an internal class.

To help identify when types are using the fallback, `-debug-only=typeid` can be
used to log which types are using implicit ids.

This change generally only requires changes to the test passes, which are all defined
in anonymous namespaces, and thus can't use the fallback any longer.

Differential Revision: https://reviews.llvm.org/D122775