[all-commits] [llvm/llvm-project] 03efa5: [flang] Update the conversion code for fir.coordin...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 03efa5a362a718b633a74cd9f1932dfa98f76a49
      https://github.com/llvm/llvm-project/commit/03efa5a362a718b633a74cd9f1932dfa98f76a49
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2022-04-04 (Mon, 04 Apr 2022)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp

  Log Message:
  -----------
  [flang] Update the conversion code for fir.coordinate_of

These are mostly small changes to make the code a bit clearer and more
consistent. Summary of changes:
  * add missing namespace qualifiers (that's the preference in Flang)
  * replace const member methods with static methods (to avoid passing
    the *this pointer unnecessarily)
  * rename `currentObjTy` (current object type) as `cpnTy` (component
    type) - the latter feels more fitting
  * remove redundant `return failure();` calls (` return
    mlir::emitError` gives the same result)
  * updated a few comments

Differential Revision: https://reviews.llvm.org/D122799