[all-commits] [llvm/llvm-project] 31cb99: [MLIR][Presburger] subtract: fix bug when an input...

[Arjun P via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 31cb99959f1766a23005325b6e93fe69ddafdffb
      https://github.com/llvm/llvm-project/commit/31cb99959f1766a23005325b6e93fe69ddafdffb
  Author: Arjun P <arjunpitchanathan at gmail.com>
  Date:   2022-04-01 (Fri, 01 Apr 2022)

  Changed paths:
    M mlir/include/mlir/Analysis/Presburger/IntegerRelation.h
    M mlir/lib/Analysis/Presburger/IntegerRelation.cpp
    M mlir/lib/Analysis/Presburger/PresburgerRelation.cpp
    M mlir/unittests/Analysis/Presburger/PresburgerSetTest.cpp

  Log Message:
  -----------
  [MLIR][Presburger] subtract: fix bug when an input set has duplicate divisions

Previously, when an input set had a duplicate division, the duplicates might
be removed by a call to mergeLocalIds due to being detected as being duplicate
for the first time. The subtraction implementation cannot handle existing
locals being removed, so this would lead to unexpected behaviour. Resolve this
by removing all the duplicates up front.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D122826