[all-commits] [llvm/llvm-project] 190541: [HLSL] Further improve to numthreads diagnostics

Chris B via All-commits all-commits at lists.llvm.org
Thu Mar 31 09:34:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19054163e11a6632b4973c936e5aa93ec742c866
      https://github.com/llvm/llvm-project/commit/19054163e11a6632b4973c936e5aa93ec742c866
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2022-03-31 (Thu, 31 Mar 2022)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/SemaDecl.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/test/SemaHLSL/num_threads.hlsl

  Log Message:
  -----------
  [HLSL] Further improve to numthreads diagnostics

This adds diagnostics for conflicting attributes on the same
declarataion, conflicting attributes on a forward and final
declaration, and defines a more narrowly scoped HLSLEntry attribute
target.

Big shout out to @aaron.ballman for the great feedback and review on
this!




More information about the All-commits mailing list