[all-commits] [llvm/llvm-project] 81f5c6: [compiler-rt] Implement __clear_cache on FreeBSD/p...

Carlo Marcelo Arenas Belón via All-commits all-commits at lists.llvm.org
Thu Mar 31 07:20:02 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 81f5c6270cdfcdf80e6296df216b696a7a37c8b5
      https://github.com/llvm/llvm-project/commit/81f5c6270cdfcdf80e6296df216b696a7a37c8b5
  Author: Carlo Marcelo Arenas Belón <carenas at gmail.com>
  Date:   2022-03-31 (Thu, 31 Mar 2022)

  Changed paths:
    M compiler-rt/lib/builtins/clear_cache.c

  Log Message:
  -----------
  [compiler-rt] Implement __clear_cache on FreeBSD/powerpc

dd9173420f06 (Add clear_cache implementation for ppc64. Fix buffer to
meet ppc64 alignment., 2017-07-28), adds an implementation for
__builtin___clear_cache on powerpc64, which was promptly ammended to
also be used with big endian mode in f67036b62c0c (This ppc64 implementation
of clear_cache works for both big and little endian., 2017-08-02)

clang will use this implementation for it's builtin on FreeBSD and result
in an abort() in the cases where 32-bit generation was requested (ex in
macppc or when the big endian powerpc64 build was done with "-m32") and as
reported[1] recently with pcre2, but there is no reason why the same code
couldn't be used in those cases, so use instead the more generic identifier
for the PowerPC architecture.

While at it, update the comment to reflect that POWER8/9 have a 128 byte
wide cache line and so the code could instead use 64 byte windows instead
but that possible optimization has been punted for now.

[1] https://github.com/PhilipHazel/pcre2/issues/92

Reviewed By: jhibbits, #powerpc, MaskRay

Differential Revision: https://reviews.llvm.org/D122640




More information about the All-commits mailing list