[all-commits] [llvm/llvm-project] b44170: [FuncSpec] Constant propagate multiple arguments f...

Alexandros Lamprineas via All-commits all-commits at lists.llvm.org
Thu Mar 31 05:08:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4417075dc1cbfac0a3f777850ba77c031d7db3c
      https://github.com/llvm/llvm-project/commit/b4417075dc1cbfac0a3f777850ba77c031d7db3c
  Author: Alexandros Lamprineas <alexandros.lamprineas at arm.com>
  Date:   2022-03-31 (Thu, 31 Mar 2022)

  Changed paths:
    M llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
    M llvm/test/Transforms/FunctionSpecialization/function-specialization-recursive.ll

  Log Message:
  -----------
  [FuncSpec] Constant propagate multiple arguments for recursive functions.

This fixes a TODO in constantArgPropagation() to make it feature complete.
However, I do find myself in agreement with the review comments in
https://reviews.llvm.org/D106426. I don't think we should pursue
specializing such recursive functions as the code size increase becomes
linear to 'max-iters'. Compiling the modified test just with -O3 (no
function specialization) generates the same code.

Differential Revision: https://reviews.llvm.org/D122755




More information about the All-commits mailing list