[all-commits] [llvm/llvm-project] ee5721: [C++20] [Modules] Use '-' as the separator of part...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee572129ae15bc15e34fcae63643d6998352dab3
      https://github.com/llvm/llvm-project/commit/ee572129ae15bc15e34fcae63643d6998352dab3
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2022-03-31 (Thu, 31 Mar 2022)

  Changed paths:
    M clang/lib/Lex/HeaderSearch.cpp
    A clang/test/Modules/search-partitions.cpp

  Log Message:
  -----------
  [C++20] [Modules] Use '-' as the separator of partitions when searching
in filesystems

It is simpler to search for module unit by -fprebuilt-module-path
option. However, the separator ':' of partitions is not friendly.
According to the discussion in https://reviews.llvm.org/D118586, I think
we get consensus to use '-' as the separator instead. The '-' is the
choice of GCC too.

Previously I thought it would be better to add an option. But I feel it
is over-engineering now. Another reason here is that there are too many
options for modules (for clang module mainly) now. Given it is not bad
to use '-' when searching, I think it is acceptable to not add an
option.

Reviewed By: iains

Differential Revision: https://reviews.llvm.org/D120874