[all-commits] [llvm/llvm-project] b97aa4: Revert "[MLIR][Presburger] LexSimplex::addEquality...

Arjun P via All-commits all-commits at lists.llvm.org
Wed Mar 30 15:26:12 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b97aa413d166c064db65051cae97068c83319a6b
      https://github.com/llvm/llvm-project/commit/b97aa413d166c064db65051cae97068c83319a6b
  Author: Arjun P <arjunpitchanathan at gmail.com>
  Date:   2022-03-30 (Wed, 30 Mar 2022)

  Changed paths:
    M mlir/include/mlir/Analysis/Presburger/Simplex.h
    M mlir/lib/Analysis/Presburger/Simplex.cpp
    M mlir/unittests/Analysis/Presburger/SimplexTest.cpp

  Log Message:
  -----------
  Revert "[MLIR][Presburger] LexSimplex::addEquality: add equalities as fixed columns"

This reverts commit 5630143af33f7e6e0dabdf38982cc9800140bb75. The
implementation in this commit was incorrect. Also, handling this representation
of equalities in the upcoming support for symbolic lexicographic minimization
makes that patch much more complex. It will be easier to review that without
this representaiton and then reintroduce the fixed column representation
later, hence the revert rather than a bug fix.




More information about the All-commits mailing list