[all-commits] [llvm/llvm-project] ff6696: Expanding HLSL attribute diagnostics

[Chris B via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff6696c842bac0b15fc04015b25ead721768eac9
      https://github.com/llvm/llvm-project/commit/ff6696c842bac0b15fc04015b25ead721768eac9
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2022-03-30 (Wed, 30 Mar 2022)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/lib/Parse/ParseDeclCXX.cpp
    M clang/test/SemaHLSL/num_threads.hlsl

  Log Message:
  -----------
  Expanding HLSL attribute diagnostics

Updating the diagnostics as per the feedback on
https://reviews.llvm.org/D122627.

This change correctly handles missing argument lists, and changes the
subject for the `numthreads` attribute to be global functions.

I did not handle applying the attribute to template functions because
that currently fails parsing in a way that is consisetent with the
current DXC codebase (Microsoft attributes are not supported on
templates).

A future improvement to the diagnostic maybe warranted.