[all-commits] [llvm/llvm-project] 39772d: [AIX][XCOFF] address post-commit review comments o...

[diggerlin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39772da5fd019a5f36c88315d08f10fab72ac2ef
      https://github.com/llvm/llvm-project/commit/39772da5fd019a5f36c88315d08f10fab72ac2ef
  Author: zhijian <zhijian at ca.ibm.com>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M llvm/include/llvm/Object/XCOFFObjectFile.h
    R llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-32-xlc-exec
    R llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-32-xlc-obj-malform.o
    R llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-32-xlc-obj.o
    R llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-64-xlc-exec
    A llvm/test/tools/llvm-readobj/XCOFF/Inputs/xlc32-exec
    A llvm/test/tools/llvm-readobj/XCOFF/Inputs/xlc32-obj-malform.o
    A llvm/test/tools/llvm-readobj/XCOFF/Inputs/xlc32-obj.o
    A llvm/test/tools/llvm-readobj/XCOFF/Inputs/xlc64-exec
    R llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test
    M llvm/test/tools/yaml2obj/XCOFF/aux-hdr-defaults.yaml
    M llvm/test/tools/yaml2obj/XCOFF/aux-hdr-full-contents.yaml
    M llvm/test/tools/yaml2obj/XCOFF/basic-doc.yaml
    M llvm/test/tools/yaml2obj/XCOFF/basic-doc64.yaml
    M llvm/test/tools/yaml2obj/XCOFF/full-contents.yaml
    M llvm/tools/llvm-readobj/Opts.td
    M llvm/tools/llvm-readobj/XCOFFDumper.cpp

  Log Message:
  -----------
  [AIX][XCOFF] address post-commit review comments of patch https://reviews.llvm.org/D82549
Summary:
Address post-commit review comments in the https://reviews.llvm.org/D82549, including

changed file name from llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test --> llvm/test/tools/llvm-readobj/XCOFF/auxiliary-header.test
replaced macro define by using lambda function.
added a helper function to reduce the duplicated check and print error code.

Reviewer : James Henderson
Differential Revision: https://reviews.llvm.org/D116220