[all-commits] [llvm/llvm-project] 16524d: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked c...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Mar 28 09:43:52 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 16524d2f1bdc2e74ca34425edf43ac8ef5d39531
      https://github.com/llvm/llvm-project/commit/16524d2f1bdc2e74ca34425edf43ac8ef5d39531
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/AVR.cpp
    M clang/lib/Driver/ToolChains/AVR.h
    R clang/test/Driver/avr-link-no-mcu-specified.c
    M clang/test/Driver/avr-toolchain.c

  Log Message:
  -----------
  [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

Many options (-fsyntax-only, -E, -S, etc) skip the link action phase which the
existing condition does not account for.

Since the code no longer specifies OPT_c, I think a single RUN line about -c
not leading to a warning is sufficient. Adding one for all of -E,
-fsyntax-only, -S would be excessive.

Reviewed By: benshi001

Differential Revision: https://reviews.llvm.org/D122553




More information about the All-commits mailing list