[all-commits] [llvm/llvm-project] a8c277: [NVPTX] Fix poorly designed assertion introduced i...

[Daniil Kovalev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a8c277041aafc0b0753cf191a4891153a2d7679c
      https://github.com/llvm/llvm-project/commit/a8c277041aafc0b0753cf191a4891153a2d7679c
  Author: Daniil Kovalev <daniil at kovalev.website>
  Date:   2022-03-28 (Mon, 28 Mar 2022)

  Changed paths:
    M llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
    A llvm/test/CodeGen/NVPTX/nvvm-annotations-D120129.ll

  Log Message:
  -----------
  [NVPTX] Fix poorly designed assertion introduced in D120129

NVPTXTargetLowering::getFunctionParamOptimizedAlign, which was introduces in
D120129, contained a poorly designed assertion checking that a function with
internal or private linkage is not a kernel. It relied on invariants that
were not actually guaranteed, and that resulted in compiler crash with some
CUDA versions (see discussion with @jdoerfert in D120129). This patch changes
that assertion and makes it use isKernelFunction which is designed exactly for
such checks. This patch also includes a test with IR that caused compiler crash
before.

Differential Revision: https://reviews.llvm.org/D122562