[all-commits] [llvm/llvm-project] 271e8d: [X86][tablgen] Refine the class RecognizableInstr....

[KanRobert via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 271e8d2495e2194c25cb786b84ab86d15184aac3
      https://github.com/llvm/llvm-project/commit/271e8d2495e2194c25cb786b84ab86d15184aac3
  Author: Shengchen Kan <shengchen.kan at intel.com>
  Date:   2022-03-26 (Sat, 26 Mar 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrTSX.td
    M llvm/utils/TableGen/X86EVEX2VEXTablesEmitter.cpp
    M llvm/utils/TableGen/X86FoldTablesEmitter.cpp
    M llvm/utils/TableGen/X86MnemonicTables.cpp
    M llvm/utils/TableGen/X86RecognizableInstr.cpp
    M llvm/utils/TableGen/X86RecognizableInstr.h

  Log Message:
  -----------
  [X86][tablgen] Refine the class RecognizableInstr. NFCI

1. Add comments to explain why we set `isAsmParserOnly` for XACQUIRE and XRELEASE
2. Check `X86Inst` in the constructor of `RecognizableInstrBase` so that
   we can avoid the case where one of it's field is not initialized but
   accessed by user. (e.g. in X86EVEX2VEXTablesEmitter.cpp)
3. Move `Rec` from `RecognizableInstrBase` to `RecognizableInstr` to reduce
   size of `RecognizableInstrBase`
4. Remove out-of-date comments for shouldBeEmitted() (filter() was removed)
5. Add a basic field `IsAsmParserOnly` and remove the field
   `ShouldBeEmitted` b/c we can deduce it w/ little overhead