[all-commits] [llvm/llvm-project] c37acc: [Option] Avoid using the default argument for the ...

Fangrui Song via All-commits all-commits at lists.llvm.org
Sat Mar 26 00:57:19 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c37accf0a207a09b80c1109eb7a114876c45f959
      https://github.com/llvm/llvm-project/commit/c37accf0a207a09b80c1109eb7a114876c45f959
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-03-26 (Sat, 26 Mar 2022)

  Changed paths:
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/SanitizerArgs.cpp
    M clang/lib/Driver/ToolChains/AMDGPU.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/HIPAMD.cpp
    M clang/lib/Frontend/CompilerInvocation.cpp
    M lld/COFF/Driver.cpp
    M llvm/tools/llvm-objcopy/ObjcopyOptions.cpp

  Log Message:
  -----------
  [Option] Avoid using the default argument for the 3-argument hasFlag. NFC

The default argument true is error-prone: I think many would think the
default is false.




More information about the All-commits mailing list