[all-commits] [llvm/llvm-project] 174cab: [flang] Fix cycle-catcher in procedure characteriz...

[Peter Klausler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 174cabeda57d8d53601d2970b426bf9ee865f2f4
      https://github.com/llvm/llvm-project/commit/174cabeda57d8d53601d2970b426bf9ee865f2f4
  Author: Peter Klausler <pklausler at nvidia.com>
  Date:   2022-03-25 (Fri, 25 Mar 2022)

  Changed paths:
    M flang/lib/Evaluate/characteristics.cpp

  Log Message:
  -----------
  [flang] Fix cycle-catcher in procedure characterization

The "seenProcs" sets passed as arguments to the procedure and dummy
procedure characterization routines need to be passed by value so that
local updates to those sets do not become permanent.  They are
presently passed by reference and that has led to bogus errors about
recursively defined procedures in testing.

(It might be faster to pass the sets by reference and undo those local
updates in these functions, but that's error-prone, and the performance
difference is not expected to be detectable in practice.)

Differential Revision: https://reviews.llvm.org/D122439