[all-commits] [llvm/llvm-project] b0dc2f: [lldb] Don't persist the LINKEDIT slide in the ind...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b0dc2fae602579114525353c8403d6e6d128ad73
      https://github.com/llvm/llvm-project/commit/b0dc2fae602579114525353c8403d6e6d128ad73
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

  Log Message:
  -----------
  [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

The current code increment the indirect symbol offset with the LINKEDIT
slide every time ObjectFileMachO::ParseSymtab is called.

This resulted in a crash when calling add-dsym which causes us to
potentially re-parse the original binary's symbol table. There's a
separate question about whether we should re-parse the symbol table at
all which was fixed by D114288. Regardless, copying the load command is
cheap enough that this is still the right thing to do.

rdar://72337717

Differential revision: https://reviews.llvm.org/D122349