[all-commits] [llvm/llvm-project] a765f2: [lldb] Support class_ro_t pointer authentication

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Mar 23 16:20:25 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a765f2a04460c5a8b814382ff969a8085e36269b
      https://github.com/llvm/llvm-project/commit/a765f2a04460c5a8b814382ff969a8085e36269b
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp

  Log Message:
  -----------
  [lldb] Support class_ro_t pointer authentication

Upstream support for signed class_ro_t pointers.


  Commit: b0f1f3b95cd5f3e951e316fea39feca9a2878942
      https://github.com/llvm/llvm-project/commit/b0f1f3b95cd5f3e951e316fea39feca9a2878942
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M lldb/source/Interpreter/CommandInterpreter.cpp

  Log Message:
  -----------
  [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

The assertion checks that the command output doesn't contain any null
bytes. I'm not sure if the intention was to make sure the string wasn't
shorter than the reported length or if this was a way to catch us
accidentally writing an (unformatted) null byte.

The consensus is that we don't want to have embedded nulls in the
command output, but that this isn't the right place to enforce that.

Differential revision: https://reviews.llvm.org/D122025


Compare: https://github.com/llvm/llvm-project/compare/0396e229cdcb...b0f1f3b95cd5


More information about the All-commits mailing list