[all-commits] [llvm/llvm-project] 94fd00: [Concepts] Fix placeholder constraints when refere...

royjacobson via All-commits all-commits at lists.llvm.org
Wed Mar 23 08:15:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94fd00f41ebddf84148f494410130527169d9573
      https://github.com/llvm/llvm-project/commit/94fd00f41ebddf84148f494410130527169d9573
  Author: Roy Jacobson <roi.jacobson1 at gmail.com>
  Date:   2022-03-23 (Wed, 23 Mar 2022)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/test/SemaTemplate/concepts.cpp

  Log Message:
  -----------
  [Concepts] Fix placeholder constraints when references are involved

Placeholder types were not checked for constraint satisfaction when modified by references or pointers.
The behavior now matches that of GCC and MSVC.

Are there other modifiers we might need to "peel"? I'm not sure my approach to this is the 'right' way to fix this, the loop feels a bit clunky.

GitHub issues [[ https://github.com/llvm/llvm-project/issues/54443 | #54443 ]], [[ https://github.com/llvm/llvm-project/issues/53911 | #53911 ]]

Reviewed By: erichkeane

Differential Revision: https://reviews.llvm.org/D122083




More information about the All-commits mailing list