[all-commits] [llvm/llvm-project] d83a70: [mlir][sparse] Distinguishing "shape" from "sizes"...
wren romano via All-commits
all-commits at lists.llvm.org
Tue Mar 22 14:16:14 PDT 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: d83a7068277eaa1b402e95df9b6eb2e0cc701243
https://github.com/llvm/llvm-project/commit/d83a7068277eaa1b402e95df9b6eb2e0cc701243
Author: wren romano <2998727+wrengr at users.noreply.github.com>
Date: 2022-03-22 (Tue, 22 Mar 2022)
Changed paths:
M mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
Log Message:
-----------
[mlir][sparse] Distinguishing "shape" from "sizes" in variable names
I'm using "shape" to mean the compile-time object, where zeros indicate sizes which are compile-time dynamic; and using "sizes" to mean the run-time object, where zeros indicate a dimension with no coordinates (hence resulting in trivial storage). Because their semantics differ on zeros, it's important to keep them distinguished. Although we do not define separate C++ types to capture the distinction, we can at least use variable names to do so.
This is (tangential) work towards fixing: https://github.com/llvm/llvm-project/issues/51652
Depends On D122057
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D122058
More information about the All-commits
mailing list