[all-commits] [llvm/llvm-project] 110295: [mlir][sparse] Moving lexOrder from SparseTensorCO...

wren romano via All-commits all-commits at lists.llvm.org
Tue Mar 22 13:07:20 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 110295ebb76150887a5a83733d7ddcf8506da9ad
      https://github.com/llvm/llvm-project/commit/110295ebb76150887a5a83733d7ddcf8506da9ad
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-03-22 (Tue, 22 Mar 2022)

  Changed paths:
    M mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

  Log Message:
  -----------
  [mlir][sparse] Moving lexOrder from SparseTensorCOO to Element

This is the more logical place for the function to live.  If/when we factor out a separate class for just the `Coordinates` themselves, then the definition should be moved to `Coordinates::lexOrder` (and `Element::lexOrder` would become a thin wrapper delegating to that function).

This is (tangentially) work towards fixing: https://github.com/llvm/llvm-project/issues/51652

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D122057




More information about the All-commits mailing list