[all-commits] [llvm/llvm-project] 86cc73: [WebAssembly] Always emit functype directives for ...

[Alex Bradbury via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 86cc731f4c50370b2ea715adcf1d07dd3db49207
      https://github.com/llvm/llvm-project/commit/86cc731f4c50370b2ea715adcf1d07dd3db49207
  Author: Alex Bradbury <asb at igalia.com>
  Date:   2022-03-22 (Tue, 22 Mar 2022)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
    M llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.h
    M llvm/test/CodeGen/WebAssembly/byval.ll
    M llvm/test/CodeGen/WebAssembly/cfg-stackify-eh.ll
    M llvm/test/CodeGen/WebAssembly/function-pointer64.ll
    M llvm/test/CodeGen/WebAssembly/functype-emission.ll
    M llvm/test/CodeGen/WebAssembly/inlineasm-output-template.ll
    M llvm/test/CodeGen/WebAssembly/multi-return.ll
    M llvm/test/CodeGen/WebAssembly/stack-protector.ll
    M llvm/test/MC/WebAssembly/stack-ptr-mclower.ll

  Log Message:
  -----------
  [WebAssembly] Always emit functype directives for defined functions

This fixes bug <https://github.com/llvm/llvm-project/issues/54022>. For
now this means that defined functions will have two .functype directives
emitted. Given discussion in that bug has suggested interest in moving
towards using something other than .functype to mark the beginning of a
function (which would, as a side-effect, solve this issue), this patch
doesn't attempt to avoid that duplication.

Some test cases that used CHECK-LABEL: foo rather than CHECK-LABEL: foo:
are broken by this change. This patch updates those test cases to always
have a colon at the end of the CHECK-LABEL string.

Differential Revision: https://reviews.llvm.org/D122134