[all-commits] [llvm/llvm-project] afc2f0: [llmv-pdbutil] Replace ExitOnError with explicit e...

Carlos Alberto Enciso via All-commits all-commits at lists.llvm.org
Sun Mar 20 22:28:16 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: afc2f024462951d6e74c5e733f4b4666e21d3309
      https://github.com/llvm/llvm-project/commit/afc2f024462951d6e74c5e733f4b4666e21d3309
  Author: Carlos Alberto Enciso <carlos.alberto.enciso at gmail.com>
  Date:   2022-03-21 (Mon, 21 Mar 2022)

  Changed paths:
    M llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
    M llvm/tools/llvm-pdbutil/InputFile.cpp

  Log Message:
  -----------
  [llmv-pdbutil] Replace ExitOnError with explicit error handling.

At Sony we are developing llvm-dva

https://lists.llvm.org/pipermail/llvm-dev/2020-August/144174.html

For its PDB support, it requires functionality already present
in llvm-pdbutil.

We intend to move that functionaly into the PDB library to be
shared by both tools. That change will be done in 2 steps, that
will be submitted as 2 patches:

(1) Replace 'ExitOnError' with explicit error handling.
(2) Move the intended shared code to the PDB library.

This patch is for step (1).

As 'ExitOnError' is intended to be used only in tool code, replace
all occurrences in the code that will be moved to the PDB library
with explicit error handling.

Reviewed By: aganea, dblaikie, rnk

Differential Revision: https://reviews.llvm.org/D121801




More information about the All-commits mailing list