[all-commits] [llvm/llvm-project] 1ae3c4: [X86] combineAddOrSubToADCOrSBB - split to more cl...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sun Mar 20 02:32:22 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ae3c4e948f884b36a7b1257ca94c665015744ca
      https://github.com/llvm/llvm-project/commit/1ae3c4e948f884b36a7b1257ca94c665015744ca
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-03-20 (Sun, 20 Mar 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] combineAddOrSubToADCOrSBB - split to more cleanly handle commuted variants.

Split combineAddOrSubToADCOrSBB into wrapper (which handles ADDs with commuted args) and the real combine, which no longer has to account for commutation.

I'm intending to extend combineAddOrSubToADCOrSBB to detect patterns other than just X86ISD::SETCC, so we need to detect all patterns without detecting them as part of a commutation swap.


  Commit: 06fa67dc0a5f0faaacb085b096521f5a8aeb4da8
      https://github.com/llvm/llvm-project/commit/06fa67dc0a5f0faaacb085b096521f5a8aeb4da8
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-03-20 (Sun, 20 Mar 2022)

  Changed paths:
    M llvm/test/CodeGen/X86/add-sub-bool.ll

  Log Message:
  -----------
  [X86] Add test add with bit0 extraction and improve comments

Based on feedback from D122084


Compare: https://github.com/llvm/llvm-project/compare/e58dadf3e2c1...06fa67dc0a5f


More information about the All-commits mailing list