[all-commits] [llvm/llvm-project] d10c0c: [lldb] Migrate condition evaluation failure to Rep...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d10c0c7b187d6a5d7a24544d70998f8d348b4dfd
      https://github.com/llvm/llvm-project/commit/d10c0c7b187d6a5d7a24544d70998f8d348b4dfd
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-03-16 (Wed, 16 Mar 2022)

  Changed paths:
    M lldb/source/Target/StopInfo.cpp
    A lldb/test/Shell/Breakpoint/invalid-condition.test

  Log Message:
  -----------
  [lldb] Migrate condition evaluation failure to ReportError

Migrate to using ReportError to report a failure to evaluate a
watchpoint condition. I had already done so for the parallel code for
breakpoints.

In the process, I noticed that I accidentally regressed the error
reporting for breakpoint conditions by dropping the call to
GetDescription. This patch rectifies that and adds a test.

Because the call to GetDescription expects a Stream*, I also switches
from using a raw_string_ostream to a StreamString for both breakpoints
and watchpoints.