[all-commits] [llvm/llvm-project] 365506: [mlir] Move the Builtin FuncOp to the Func dialect

River Riddle via All-commits all-commits at lists.llvm.org
Wed Mar 16 17:15:29 PDT 2022 

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 36550692340e4235550f3b9808b5e406821cc979
      https://github.com/llvm/llvm-project/commit/36550692340e4235550f3b9808b5e406821cc979
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-03-16 (Wed, 16 Mar 2022)

  Changed paths:
    M flang/include/flang/Lower/CallInterface.h
    M flang/include/flang/Optimizer/Builder/FIRBuilder.h
    M flang/include/flang/Optimizer/Builder/LowLevelIntrinsics.h
    M flang/test/Fir/Todo/boxproc_host.fir
    M flang/test/Fir/Todo/unboxproc.fir
    M flang/unittests/Optimizer/Builder/CharacterTest.cpp
    M flang/unittests/Optimizer/Builder/ComplexTest.cpp
    M flang/unittests/Optimizer/Builder/FIRBuilderTest.cpp
    M flang/unittests/Optimizer/Builder/Runtime/RuntimeCallTestBase.h
    M mlir/benchmark/python/benchmark_sparse.py
    M mlir/benchmark/python/common.py
    M mlir/docs/Bindings/Python.md
    M mlir/docs/Dialects/ShapeDialect.md
    M mlir/docs/PassManagement.md
    M mlir/docs/SymbolsAndSymbolTables.md
    M mlir/docs/TargetLLVMIR.md
    M mlir/include/mlir/Dialect/Affine/LoopUtils.h
    M mlir/include/mlir/Dialect/Affine/Passes.h
    M mlir/include/mlir/Dialect/Affine/Utils.h
    M mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.h
    M mlir/include/mlir/Dialect/Bufferization/Transforms/Passes.td
    M mlir/include/mlir/Dialect/Func/IR/FuncOps.h
    M mlir/include/mlir/Dialect/Func/IR/FuncOps.td
    M mlir/include/mlir/Dialect/Func/Transforms/Passes.td
    M mlir/include/mlir/Dialect/GPU/Passes.h
    M mlir/include/mlir/Dialect/Linalg/Analysis/DependenceAnalysis.h
    M mlir/include/mlir/Dialect/Linalg/Passes.h
    M mlir/include/mlir/Dialect/Linalg/Transforms/Hoisting.h
    M mlir/include/mlir/Dialect/Quant/Passes.h
    M mlir/include/mlir/Dialect/SCF/Utils/Utils.h
    M mlir/include/mlir/Dialect/Shape/IR/Shape.h
    M mlir/include/mlir/IR/BuiltinOps.h
    M mlir/include/mlir/IR/BuiltinOps.td
    M mlir/include/mlir/IR/FunctionInterfaces.td
    M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
    M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
    M mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRVPass.cpp
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
    M mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
    M mlir/lib/Dialect/Affine/Transforms/PassDetail.h
    M mlir/lib/Dialect/Affine/Utils/LoopFusionUtils.cpp
    M mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
    M mlir/lib/Dialect/Affine/Utils/Utils.cpp
    M mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
    M mlir/lib/Dialect/Bufferization/IR/CMakeLists.txt
    M mlir/lib/Dialect/Bufferization/Transforms/PassDetail.h
    M mlir/lib/Dialect/Func/IR/FuncOps.cpp
    M mlir/lib/Dialect/Func/Transforms/FuncBufferize.cpp
    M mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp
    M mlir/lib/Dialect/GPU/Transforms/PassDetail.h
    M mlir/lib/Dialect/Linalg/Analysis/DependenceAnalysis.cpp
    M mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgStrategyPasses.cpp
    M mlir/lib/Dialect/Linalg/Transforms/PassDetail.h
    M mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
    M mlir/lib/Dialect/Quant/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/Quant/Transforms/PassDetail.h
    M mlir/lib/Dialect/SCF/Transforms/PassDetail.h
    M mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
    M mlir/lib/Dialect/Shape/IR/CMakeLists.txt
    M mlir/lib/Dialect/Shape/Transforms/PassDetail.h
    M mlir/lib/Dialect/SparseTensor/Pipelines/SparseTensorPipelines.cpp
    M mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
    M mlir/lib/Dialect/Tensor/Transforms/PassDetail.h
    M mlir/lib/Dialect/Vector/Transforms/PassDetail.h
    M mlir/lib/IR/BuiltinDialect.cpp
    M mlir/lib/Pass/PassRegistry.cpp
    M mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
    M mlir/lib/Transforms/Utils/InliningUtils.cpp
    M mlir/python/mlir/dialects/_builtin_ops_ext.py
    M mlir/python/mlir/dialects/_func_ops_ext.py
    M mlir/test/Analysis/test-alias-analysis-modref.mlir
    M mlir/test/Analysis/test-alias-analysis.mlir
    M mlir/test/Analysis/test-dominance.mlir
    M mlir/test/Analysis/test-liveness.mlir
    M mlir/test/Analysis/test-match-reduction.mlir
    M mlir/test/Analysis/test-shape-fn-report.mlir
    M mlir/test/Analysis/test-topoligical-sort.mlir
    M mlir/test/CAPI/execution_engine.c
    M mlir/test/CAPI/ir.c
    M mlir/test/CAPI/pass.c
    M mlir/test/Conversion/ArithmeticToLLVM/arith-to-llvm.mlir
    M mlir/test/Conversion/ArithmeticToLLVM/convert-nd-vector-to-llvmir.mlir
    M mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir
    M mlir/test/Conversion/ComplexToStandard/full-conversion.mlir
    M mlir/test/Conversion/FuncToLLVM/func-memref.mlir
    M mlir/test/Conversion/FuncToLLVM/func-to-llvm.mlir
    M mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir
    M mlir/test/Conversion/GPUToNVVM/wmma-ops-to-nvvm.mlir
    M mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir
    M mlir/test/Conversion/MathToLLVM/math-to-llvm.mlir
    M mlir/test/Conversion/SCFToGPU/no_blocks_no_threads.mlir
    M mlir/test/Conversion/SCFToGPU/step_one.mlir
    M mlir/test/Conversion/SCFToGPU/step_positive.mlir
    M mlir/test/Conversion/ShapeToStandard/convert-shape-constraints.mlir
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg-named.mlir
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir
    M mlir/test/Conversion/VectorToGPU/vector-to-mma-ops.mlir
    M mlir/test/Conversion/VectorToROCDL/vector-to-rocdl.mlir
    M mlir/test/Conversion/VectorToSCF/tensor-transfer-ops.mlir
    M mlir/test/Conversion/VectorToSCF/unrolled-tensor-transfer-ops.mlir
    M mlir/test/Conversion/VectorToSCF/unrolled-vector-to-loops.mlir
    M mlir/test/Conversion/VectorToSCF/vector-to-scf-mask-and-permutation-map.mlir
    M mlir/test/Conversion/VectorToSCF/vector-to-scf.mlir
    M mlir/test/Dialect/Affine/canonicalize.mlir
    M mlir/test/Dialect/Affine/loop-unswitch.mlir
    M mlir/test/Dialect/Affine/memref-stride-calculation.mlir
    M mlir/test/Dialect/ControlFlow/canonicalize.mlir
    M mlir/test/Dialect/LLVMIR/terminator.mlir
    M mlir/test/Dialect/Linalg/comprehensive-module-bufferize-analysis.mlir
    M mlir/test/Dialect/Linalg/convert-elementwise-to-linalg.mlir
    M mlir/test/Dialect/Linalg/detensorize_0d.mlir
    M mlir/test/Dialect/Linalg/detensorize_br_operands.mlir
    M mlir/test/Dialect/Linalg/detensorize_if.mlir
    M mlir/test/Dialect/Linalg/detensorize_trivial.mlir
    M mlir/test/Dialect/Linalg/detensorize_while.mlir
    M mlir/test/Dialect/Linalg/detensorize_while_impure_cf.mlir
    M mlir/test/Dialect/Linalg/detensorize_while_pure_cf.mlir
    M mlir/test/Dialect/Linalg/drop-unit-extent-dims.mlir
    M mlir/test/Dialect/Linalg/fold-unit-trip-loops.mlir
    M mlir/test/Dialect/Linalg/fusion-sequence.mlir
    M mlir/test/Dialect/Linalg/tile-and-fuse-no-fuse.mlir
    M mlir/test/Dialect/Linalg/tile-and-fuse-on-tensors.mlir
    M mlir/test/Dialect/Linalg/tile-and-fuse-sequence-on-tensors.mlir
    M mlir/test/Dialect/Quant/canonicalize.mlir
    M mlir/test/Dialect/SCF/canonicalize.mlir
    M mlir/test/Dialect/SCF/for-loop-to-while-loop.mlir
    M mlir/test/Dialect/SCF/loop-range.mlir
    M mlir/test/Dialect/SCF/parallel-loop-fusion.mlir
    M mlir/test/Dialect/SCF/parallel-loop-tiling-inbound-check.mlir
    M mlir/test/Dialect/SCF/parallel-loop-tiling.mlir
    M mlir/test/Dialect/SPIRV/Transforms/canonicalize.mlir
    M mlir/test/Dialect/Shape/invalid.mlir
    M mlir/test/Dialect/Tensor/invalid.mlir
    M mlir/test/Dialect/Vector/canonicalize.mlir
    M mlir/test/IR/diagnostic-handler-filter.mlir
    M mlir/test/IR/generic-visitors-interrupt.mlir
    M mlir/test/IR/generic-visitors.mlir
    M mlir/test/IR/invalid-func-op.mlir
    M mlir/test/IR/invalid-ops.mlir
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/print-ir-invalid.mlir
    M mlir/test/IR/test-matchers.mlir
    M mlir/test/IR/traits.mlir
    M mlir/test/IR/visitors.mlir
    M mlir/test/IR/wrapping_op.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/benchmark_matmul.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-comprehensive-bufferize.mlir
    M mlir/test/Integration/Dialect/SparseTensor/python/test_SDDMM.py
    M mlir/test/Integration/Dialect/SparseTensor/python/test_SpMM.py
    M mlir/test/Integration/Dialect/SparseTensor/python/test_stress.py
    M mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py
    M mlir/test/Integration/Dialect/Standard/CPU/test-ceil-floor-pos-neg.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-1d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-2d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-3d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-to-loops.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-vector-distribute.mlir
    M mlir/test/Pass/dynamic-pipeline.mlir
    M mlir/test/Pass/interface-pass.mlir
    M mlir/test/Pass/invalid-parent.mlir
    M mlir/test/Pass/ir-printing.mlir
    M mlir/test/Pass/pass-timing.mlir
    M mlir/test/Pass/pipeline-options-parsing.mlir
    M mlir/test/Pass/pipeline-parsing.mlir
    M mlir/test/Pass/pipeline-stats.mlir
    M mlir/test/Pass/run-reproducer.mlir
    M mlir/test/Target/Cpp/invalid.mlir
    M mlir/test/Target/LLVMIR/arm-neon-2d.mlir
    M mlir/test/Target/LLVMIR/vector-to-llvm-ir.mlir
    M mlir/test/Transforms/canonicalize-block-merge.mlir
    M mlir/test/Transforms/canonicalize-dce.mlir
    M mlir/test/Transforms/canonicalize-td.mlir
    M mlir/test/Transforms/canonicalize.mlir
    M mlir/test/Transforms/constant-fold.mlir
    M mlir/test/Transforms/cse.mlir
    M mlir/test/Transforms/parallel-loop-collapsing.mlir
    M mlir/test/Transforms/parametric-mapping.mlir
    M mlir/test/Transforms/print-op-graph.mlir
    M mlir/test/Transforms/sccp-structured.mlir
    M mlir/test/Transforms/sccp.mlir
    M mlir/test/Transforms/single-parallel-loop-collapsing.mlir
    M mlir/test/Transforms/test-canonicalize-filter.mlir
    M mlir/test/Transforms/test-canonicalize.mlir
    M mlir/test/Transforms/test-legalizer-analysis.mlir
    M mlir/test/Transforms/test-legalizer-full.mlir
    M mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
    M mlir/test/lib/Dialect/Affine/TestAffineLoopParametricTiling.cpp
    M mlir/test/lib/Dialect/Affine/TestLoopFusion.cpp
    M mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgElementwiseFusion.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgHoisting.cpp
    M mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
    M mlir/test/lib/Dialect/SCF/TestSCFUtils.cpp
    M mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp
    M mlir/test/lib/Dialect/Test/TestDialect.h
    M mlir/test/lib/Dialect/Tosa/CMakeLists.txt
    M mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
    M mlir/test/lib/Pass/TestPassManager.cpp
    M mlir/test/mlir-cpu-runner/async-error.mlir
    M mlir/test/mlir-cpu-runner/async-group.mlir
    M mlir/test/mlir-cpu-runner/async-value.mlir
    M mlir/test/mlir-cpu-runner/async.mlir
    M mlir/test/mlir-cpu-runner/bare-ptr-call-conv.mlir
    M mlir/test/mlir-cpu-runner/copy.mlir
    M mlir/test/mlir-cpu-runner/global-memref.mlir
    M mlir/test/mlir-cpu-runner/math-polynomial-approx.mlir
    M mlir/test/mlir-cpu-runner/memref-reinterpret-cast.mlir
    M mlir/test/mlir-cpu-runner/memref-reshape.mlir
    M mlir/test/mlir-cpu-runner/sgemm-naive-codegen.mlir
    M mlir/test/mlir-cpu-runner/unranked-memref.mlir
    M mlir/test/mlir-cpu-runner/utils.mlir
    M mlir/test/mlir-lsp-server/diagnostics.test
    M mlir/test/mlir-lsp-server/hover.test
    M mlir/test/mlir-opt/async.mlir
    M mlir/test/mlir-pdll/Parser/expr-failure.pdll
    M mlir/test/mlir-pdll/Parser/stmt-failure.pdll
    M mlir/test/python/dialects/builtin.py
    M mlir/test/python/dialects/func.py
    M mlir/test/python/dialects/linalg/opdsl/emit_convolution.py
    M mlir/test/python/dialects/linalg/opdsl/emit_fill.py
    M mlir/test/python/dialects/linalg/opdsl/emit_matmul.py
    M mlir/test/python/dialects/linalg/opdsl/emit_misc.py
    M mlir/test/python/dialects/linalg/opdsl/emit_pooling.py
    M mlir/test/python/dialects/linalg/ops.py
    M mlir/test/python/dialects/math_dialect.py
    M mlir/test/python/dialects/scf.py
    M mlir/test/python/dialects/shape.py
    M mlir/test/python/dialects/tensor.py
    M mlir/test/python/dialects/vector.py
    M mlir/test/python/integration/dialects/linalg/opsrun.py
    M mlir/test/python/ir/blocks.py
    M mlir/test/python/ir/operation.py
    M mlir/test/python/pass_manager.py
    M mlir/unittests/ExecutionEngine/Invoke.cpp
    M mlir/unittests/IR/InterfaceAttachmentTest.cpp
    M mlir/unittests/Pass/AnalysisManagerTest.cpp
    M mlir/unittests/Pass/CMakeLists.txt
    M mlir/unittests/Pass/PassManagerTest.cpp

  Log Message:
  -----------
  [mlir] Move the Builtin FuncOp to the Func dialect

This commit moves FuncOp out of the builtin dialect, and into the Func
dialect. This move has been planned in some capacity from the moment
we made FuncOp an operation (years ago). This commit handles the
functional aspects of the move, but various aspects are left untouched
to ease migration: func::FuncOp is re-exported into mlir to reduce
the actual API churn, the assembly format still accepts the unqualified
`func`. These temporary measures will remain for a little while to
simplify migration before being removed.

Differential Revision: https://reviews.llvm.org/D121266


  Commit: 4a3460a7917f1cf514575759e29590b388131fc6
      https://github.com/llvm/llvm-project/commit/4a3460a7917f1cf514575759e29590b388131fc6
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-03-16 (Wed, 16 Mar 2022)

  Changed paths:
    M flang/lib/Lower/Allocatable.cpp
    M flang/lib/Lower/ConvertExpr.cpp
    M flang/lib/Lower/HostAssociations.cpp
    M flang/lib/Lower/IO.cpp
    M flang/lib/Lower/IntrinsicCall.cpp
    M flang/lib/Lower/Runtime.cpp
    M flang/lib/Optimizer/Builder/Character.cpp
    M flang/lib/Optimizer/Builder/Runtime/Assign.cpp
    M flang/lib/Optimizer/Builder/Runtime/Character.cpp
    M flang/lib/Optimizer/Builder/Runtime/Command.cpp
    M flang/lib/Optimizer/Builder/Runtime/Derived.cpp
    M flang/lib/Optimizer/Builder/Runtime/Inquiry.cpp
    M flang/lib/Optimizer/Builder/Runtime/Numeric.cpp
    M flang/lib/Optimizer/Builder/Runtime/Ragged.cpp
    M flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
    M flang/lib/Optimizer/Builder/Runtime/Stop.cpp
    M flang/lib/Optimizer/Builder/Runtime/Transformational.cpp
    M flang/lib/Optimizer/CodeGen/TargetRewrite.cpp
    M flang/lib/Optimizer/Dialect/FIROps.cpp
    M flang/lib/Optimizer/Transforms/AbstractResult.cpp
    M mlir/docs/Bindings/Python.md
    M mlir/examples/toy/Ch2/include/toy/Ops.td
    M mlir/examples/toy/Ch2/mlir/Dialect.cpp
    M mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
    M mlir/examples/toy/Ch3/include/toy/Ops.td
    M mlir/examples/toy/Ch3/mlir/Dialect.cpp
    M mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
    M mlir/examples/toy/Ch4/include/toy/Ops.td
    M mlir/examples/toy/Ch4/mlir/Dialect.cpp
    M mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
    M mlir/examples/toy/Ch5/include/toy/Ops.td
    M mlir/examples/toy/Ch5/mlir/Dialect.cpp
    M mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
    M mlir/examples/toy/Ch6/include/toy/Ops.td
    M mlir/examples/toy/Ch6/mlir/Dialect.cpp
    M mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
    M mlir/examples/toy/Ch7/include/toy/Ops.td
    M mlir/examples/toy/Ch7/mlir/Dialect.cpp
    M mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp
    M mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
    M mlir/include/mlir/Dialect/Func/IR/FuncOps.td
    M mlir/include/mlir/Dialect/GPU/GPUOps.td
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
    M mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
    M mlir/include/mlir/IR/FunctionInterfaces.h
    M mlir/include/mlir/IR/FunctionInterfaces.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
    M mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp
    M mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp
    M mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRVPass.cpp
    M mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
    M mlir/lib/Dialect/Async/Transforms/AsyncParallelFor.cpp
    M mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
    M mlir/lib/Dialect/Bufferization/Transforms/BufferResultsToOutParams.cpp
    M mlir/lib/Dialect/Func/IR/FuncOps.cpp
    M mlir/lib/Dialect/Func/Transforms/DecomposeCallGraphTypes.cpp
    M mlir/lib/Dialect/Func/Transforms/FuncBufferize.cpp
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp
    M mlir/lib/Dialect/MemRef/Transforms/NormalizeMemRefs.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
    M mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
    M mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp
    M mlir/lib/ExecutionEngine/JitRunner.cpp
    M mlir/lib/Target/Cpp/TranslateToCpp.cpp
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/python/mlir/dialects/_func_ops_ext.py
    M mlir/test/CAPI/ir.c
    M mlir/test/Dialect/GPU/invalid.mlir
    M mlir/test/Dialect/GPU/ops.mlir
    M mlir/test/Dialect/LLVMIR/func.mlir
    M mlir/test/IR/invalid-func-op.mlir
    M mlir/test/IR/parser.mlir
    M mlir/test/lib/Dialect/Func/TestDecomposeCallGraphTypes.cpp
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp
    M mlir/test/lib/IR/TestFunc.cpp
    M mlir/test/lib/IR/TestSlicing.cpp
    M mlir/test/mlir-lsp-server/hover.test

  Log Message:
  -----------
  [mlir:FunctionOpInterface] Rename the "type" attribute to "function_type"

This removes any potential confusion with the `getType` accessors
which correspond to SSA results of an operation, and makes it
clear what the intent is (i.e. to represent the type of the function).

Differential Revision: https://reviews.llvm.org/D121762


Compare: https://github.com/llvm/llvm-project/compare/f4548ed7fc4f...4a3460a7917f

More information about the All-commits mailing list