[all-commits] [llvm/llvm-project] 78669c: [libc++][tests] Use CMake provided paths for inclu...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 78669c4185e4f8784308b5e740721cd374052cae
      https://github.com/llvm/llvm-project/commit/78669c4185e4f8784308b5e740721cd374052cae
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-03-16 (Wed, 16 Mar 2022)

  Changed paths:
    M libcxx/test/configs/apple-libc++-backdeployment.cfg.in
    M libcxx/test/configs/apple-libc++-shared.cfg.in
    M libcxx/test/configs/cmake-bridge.cfg.in
    M libcxx/test/configs/ibm-libc++-shared.cfg.in
    M libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
    M libcxx/utils/ci/run-buildbot
    M libcxx/utils/libcxx/test/config.py
    M libcxxabi/test/configs/apple-libc++abi-backdeployment.cfg.in
    M libcxxabi/test/configs/apple-libc++abi-shared.cfg.in
    M libcxxabi/test/configs/cmake-bridge.cfg.in
    M libcxxabi/test/configs/ibm-libc++abi-shared.cfg.in
    M libcxxabi/test/vendor/apple/system-install-properties.sh.cpp

  Log Message:
  -----------
  [libc++][tests] Use CMake provided paths for includes and libdir instead of hardcoding them

In the new-style testing configurations, we were hardcoding paths to the
`include` and `lib` directories, which was incorrect but always went
unnoticed because the hardcoded values always happened to match the
actual value.

When using new-style configs with the bootstrapping build, this falls
appart -- and we never noticed this because the bootstrapping build was
still using old style configs.

This patch removes the %{install} substitution, which makes it too
tempting to hardcode installation paths, and it also switches the
bootstrapping build to actually using new-style configs like we
always intended to do.

Differential Revision: https://reviews.llvm.org/D121700