[all-commits] [llvm/llvm-project] 541d89: [mlir] Fix --convert-func-to-llvm=emit-c-wrappers ...

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 541d89b02c10997477f9109945b1d700d6a78c65
      https://github.com/llvm/llvm-project/commit/541d89b02c10997477f9109945b1d700d6a78c65
  Author: Sam Carroll <sam.carroll at lmns.com>
  Date:   2022-03-15 (Tue, 15 Mar 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    A mlir/test/Conversion/StandardToLLVM/emit-c-wrappers-for-external-callers.mlir
    A mlir/test/Conversion/StandardToLLVM/emit-c-wrappers-for-external-functions.mlir
    M mlir/test/Dialect/LLVMIR/func.mlir
    M mlir/test/Dialect/LLVMIR/invalid.mlir

  Log Message:
  -----------
  [mlir] Fix --convert-func-to-llvm=emit-c-wrappers argument and result attribute handling

When using `--convert-func-to-llvm=emit-c-wrappers` the attribute arguments of the wrapper would not be created correctly in some cases.
This patch fixes that and introduces a set of tests for (hopefully) all corner cases.

See https://github.com/llvm/llvm-project/issues/53503

Author: Sam Carroll <sam.carroll at lmns.com>
Co-Author: Laszlo Kindrat <laszlo.kindrat at lmns.com>

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D119895