[all-commits] [llvm/llvm-project] 294eca: [regalloc] Remove -consider-local-interval-cost

Mircea Trofin via All-commits all-commits at lists.llvm.org
Mon Mar 14 10:49:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 294eca35a00f89dff474044ebd478a7f83ccc310
      https://github.com/llvm/llvm-project/commit/294eca35a00f89dff474044ebd478a7f83ccc310
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   2022-03-14 (Mon, 14 Mar 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetSubtargetInfo.h
    M llvm/lib/CodeGen/RegAllocGreedy.cpp
    M llvm/lib/CodeGen/RegAllocGreedy.h
    M llvm/lib/CodeGen/TargetSubtargetInfo.cpp
    M llvm/lib/Target/AArch64/AArch64Subtarget.h
    M llvm/lib/Target/X86/X86Subtarget.h
    M llvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll
    R llvm/test/CodeGen/X86/bug26810.ll
    R llvm/test/CodeGen/X86/greedy_regalloc_bad_eviction_sequence.ll

  Log Message:
  -----------
  [regalloc] Remove -consider-local-interval-cost

Discussed extensively on D98232. The functionality introduced in D35816
never worked correctly. In D98232, it was fixed, but, as it was
introducing a large compile-time regression, and the value of the
original patch was called into doubt, we disabled it by default
everywhere. A year later, it appears that caused no grief, so it seems
safe to remove the disabled code.

This should be accompanied by re-opening bug 26810.

Differential Revision: https://reviews.llvm.org/D121128




More information about the All-commits mailing list